HdrHistogram / HdrHistogram/HdrHistogram_rust

Clarify tracking of highest and lowest trackable values

Open
#75 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
372
Forks
50
PR merge metrics
No merged PRs in 30d

Description

See https://github.com/jonhoo/hdrsample/pull/74#discussion_r158192909 for more context.

We save in fields (and write when serializing) the requested limits, not the actual limits that result from the underlying encoding (which will encompass at least as much as what the user requested, and maybe more). Perhaps we should expose the actual limits of what a particular histogram can do, rather than just regurgitate the limits that the user requested? This would be useful when, say, storing metadata about histograms, since the data actually in the histogram is likely more interesting than the particular subset of values that were initially requested as trackable.

Strawman:

  • configured_low() for what the user requested when creating the histogram
  • actual_low() for what the histogram can support
  • configured_high(), actual_high()

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked pull-request discussion and inspect how the requested limits are stored and written during histogram serialization. Resolve whether configured and actual limits should both be exposed and serialized; the issue does not name a file or test, and its strawman still needs a project decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.