HdrHistogram / HdrHistogram/HdrHistogram_rust

More flexible subtraction logic

Open
#37 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
372
Forks
50
PR merge metrics
No merged PRs in 30d

Description

There are two reasonable things to do when subtracting a count that exceeds the minuend count: saturate at 0, or error. It would be nice to let the user do both.

See https://github.com/jonhoo/hdrsample/pull/34/files#diff-b4aea3e418ccdb71239b96952d9cddb6R558 for more context.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the subtraction logic discussed in the linked pull request, then locate its equivalent implementation in this repository. Determine how callers should select saturating-at-zero versus erroring behavior, and verify that both modes are covered by the relevant existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.