Feature request: support floating-point numbers

Open
#128 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
java, rust
Domain
data

Research direction

Start by reading the linked Java DoubleHistogram implementation and the related HdrHistogram_rust issue, then compare them with the existing Rust Histogram implementation. Decide whether the initial work should be a separate DoubleHistogram type or a type-generic histogram; done means floating-point histogram support is implemented in Rust and its behavior matches the referenced design.

Written by the indexing model from the issue text.

Description

Feature request: support floating-point numbers

See https://github.com/HdrHistogram/HdrHistogram_rust/issues/91,

Floating point values can be supported, but they are basically a completely separate implementation that wraps an inner integer-based histogram. I'd be neat to port DoubleHistogram to Rust as well, but unfortunately it's a larger effort that I don't have time for myself at the moment. If you want to give it a try, I'd be happy to try and review? It should be a fairly straightforward translation of the Java version I linked above! I wonder if we may even be able to have a single Histogram type by providing inherent implementations for Histogram<f64>... Not entirely clear. Initially I'd just have a separate DoubleHistogram type.

If possible, I suggest implementing a type-generic histogram using num-traits.

Dominant language
Rust
Stars
372
Forks
50
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from HdrHistogram/HdrHistogram_rust

All issues in HdrHistogram/HdrHistogram_rust

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.