HdrHistogram / HdrHistogram/HdrHistogramJS

Add `minValue` to get the actual minimum value

Open
#11 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
130
Forks
18
PR merge metrics
No merged PRs in 30d

Description

Right now there is a maxValue and a minNonZeroValue, but no way to get the real minValue. This means the class needs to be wrapped to the real minimum value can be capture. This functionality should be built-in for cases where 0 is a valid value.

Given the lack of such a basic functionality, my guess is that there must be a good reason why this was not included, so happy to discuss if that's the case.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing maxValue and minNonZeroValue implementations and their tests. Add coverage for an actual minimum of 0 and for the new minValue behavior; done means callers can retrieve the real minimum without wrapping the class.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
performance
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.