HaxeFoundation / HaxeFoundation/hxcpp

Finalizers must be marked before they can be run / HXCPP_GC_GENERATIONAL

Open
#968 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
330
Forks
227
Avg merge
2d 16h
Merged PRs (30d)
18

Description

Hi,
I think i've found a bug in the GC generational,

In MarkAll gSpecialObjectLock should be locked at begin,
```
void MarkAll(bool inGenerational)
{

// Finalizers must be marked before they can be run
#ifdef HXCPP_GC_NURSERY
AutoLock lock(*gSpecialObjectLock);
#endif
```

What do you think Hugh ?
Thank you

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.