HaxeFoundation / HaxeFoundation/hxcpp

Deprecate non HX_SMART_STRINGS paths

Open
#1,353 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
330
Forks
227
Avg merge
2d 16h
Merged PRs (30d)
18

Description

Having to keep two code paths for text encoding stuff has been annoying me recently, I have two questions.

1. What is the `NO_HX_SMART_STRINGS` really for? I'm assuming this was just to switch back to the old code in case there were bugs in the new dual encoding system.
2. Is anyone actually using the non smart strings mode, if so, why? I'm assuming if anyone is they ran into a bug, disabled unicode string, and haven't touched it since.

It would be nice if for Haxe 5 we could stop supporting the fallback mode, any new api wouldn't need to support both that way.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the NO_HX_SMART_STRINGS option and all code paths controlled by it, then determine whether the fallback is still used and why. Done would require an agreed Haxe 5 deprecation or removal plan, including the effect on existing APIs and any needed migration guidance.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.