HaxeFoundation / HaxeFoundation/haxe

TyperDotPath post-refactoring cleanup

Open
#9,193 0 comments 0 reactions 1 assignee Claimed by @nadako View on GitHub
tech-debt
Dominant language
Haxe
Stars
6.9k
Forks
715
Avg merge
2d 2h
Merged PRs (30d)
11

Description

now when it's somewhat readable there are a couple things that can be cleaned up further:

* extract `field_chain` call from `resolve_dot_path` which would make its responsibility limited to "resolve given path until expression"
* return `result` instead of raising `Not_found` so we preserve proper error message and don't need to reconstruct it

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.