HaxeFoundation / HaxeFoundation/haxe

About std/haxe/Int64 inlining

Open
#5,153 2 comments 0 reactions 0 assignees View on GitHub
standard library
Dominant language
Haxe
Stars
6.9k
Forks
715
Avg merge
2d 2h
Merged PRs (30d)
11

Description

All Int64 methods are inlined for targets that don't have a custom implementation.
https://github.com/HaxeFoundation/haxe/blob/development/std/haxe/Int64.hx#L253

So for example when adding two longs all that body is inlined, and at least on javascript target that would impact on size and probably even it will have worse performance (because js engines tends to optimize better smaller methods and to inline internally when required).

Non single-line / or with several param references, public and inlined methods:
add, sub, mul, compare, ucompare, neg, preIncrement, eq, neq, and, or, xor, shl, shr, ushr, toInt, ofInt

Is this the desired behaviour?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.