HaxeFlixel / HaxeFlixel/flixel
FlxGroup: add type param to add method
Open
Nobody has claimed this yet.
Breaking Change
Improvement
Structure
- Dominant language
- Haxe
- Stars
- 2.2k
- Forks
- 522
- Avg merge
- 34m
- Merged PRs (30d)
- 1
Description
Seems as simple as:
public function add<TBasic:T>(basic:TBasic):TBasic
But this is a breaking change, even if we add this to 7.0.0 we may want to consider adding a new function people can use, leading up to 7. It just seems lame to deprecate add for a temporary addMember or something
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the FlxGroup.add method and inspect its current signature and callers to understand the compatibility impact of adding the type parameter. Review the breaking-change concern and decide whether the existing method or a new method should provide the typed return; done requires a documented API direction and corresponding implementation.
Written by the indexing model from the issue text.
Assessment
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100