HaxeFlixel / HaxeFlixel/flixel
FlxSound and FlxG.sound: Further rework load methods
Nobody has claimed this yet.
- Dominant language
- Haxe
- Stars
- 2.2k
- Forks
- 522
- Avg merge
- 34m
- Merged PRs (30d)
- 1
Description
On top of #3479, I think we need to simplify loading and playing sounds, sound.load should only load the sound, it doesn't need a setter for every field. Likewise FlxG.sound.load doesn't need to behave like loadButAlsoPlay() we have play() for that.
@ACrazyTown looping you in as I'll be modifying some of your 6.2.0 changes
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading #3479 and the existing FlxSound and FlxG.sound load methods, including loadButAlsoPlay and play. Determine the current loading and playback responsibilities, then verify that load only loads sound data and that playback remains explicit through play; check the relevant sound tests if present.
Written by the indexing model from the issue text.
Assessment
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100