HaxeFlixel / HaxeFlixel/flixel

Remove signal.destroy

Open
#3,486 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haxe
Stars
2.2k
Forks
522
Avg merge
34m
Merged PRs (30d)
1

Description

Why have a destroy when removeAll should clear all references and allow garbage collection, while still allowing the signal to be used in the future.

Tasks:

  • Deprecate destroy
  • Clear pendingRemove in removeAll

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the signal implementation and compare destroy with removeAll. Deprecate signal.destroy and ensure removeAll clears pendingRemove while leaving the signal reusable. No file or test is named in the issue, so locate the relevant signal code before changing it.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.