HaxeFlixel / HaxeFlixel/flixel
add onAdded/onRemoved?
Open
Nobody has claimed this yet.
Improvement
New Feature
- Dominant language
- Haxe
- Stars
- 2.2k
- Forks
- 522
- Avg merge
- 34m
- Merged PRs (30d)
- 1
Description
A signal (maybe typed) called when a FlxBasic's container is changed
Downsides
This can get kinda hairy with adding/removing destroyed things, some options:
- Make these signals
final onAdded = new FlxSignal();and only clear it in destroy - Don't use a signal just have a
function setContainer(value) { container = value; }that can be extended. Note: i'm not really into haxe's setters for this case. for reasons I'll list, upon request
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating FlxBasic and its container assignment path. Compare the proposed onAdded/onRemoved signals with an overridable setContainer function, including behavior for destroyed objects; done requires a settled API design and corresponding tests, but the issue names no test files.
Written by the indexing model from the issue text.
Assessment
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100