HaxeFlixel / HaxeFlixel/flixel
Better bitmap keying for FlxText
Nobody has claimed this yet.
- Dominant language
- Haxe
- Stars
- 2.2k
- Forks
- 522
- Avg merge
- 34m
- Merged PRs (30d)
- 1
Description
source: https://github.com/HaxeFlixel/flixel/blob/dev/flixel/text/FlxText.hx#L893
FlxText bitmaps are keyed by their text, this seems like it would generate a lot of bitmaps unnecessarily. ideally we would generate a new bitmap if the dimensions of a textfield change, without having different fields of the same size use the same bitmap. maybe we can use ID, or get some kinda mem address?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in flixel/text/FlxText.hx around line 893 and inspect how FlxText bitmap keys are generated and reused. Define the intended cache identity and dimensions behavior first; done means equivalent text fields reuse appropriate bitmaps without generating unnecessary entries, with coverage added wherever the existing behavior is tested.
Written by the indexing model from the issue text.
Assessment
- Domain
- game-dev, performance
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100