HaxeFlixel / HaxeFlixel/flixel
FlxTilemap and FlxTilemapExt invalid frame checks
Nobody has claimed this yet.
- Dominant language
- Haxe
- Stars
- 2.2k
- Forks
- 522
- Avg merge
- 34m
- Merged PRs (30d)
- 1
Description
FlxTilemap and FlxTilemapExt should warn on invalid frames on creation rather than on collision/drawing, it should also replace the invalid tiles with 0
brought up in https://github.com/HaxeFlixel/flixel-addons/pull/384
Edit: just remembered that checking for tiles < 0 are because many editors use -1 for empty tiles. keep that in mind when approaching this
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading FlxTilemap and FlxTilemapExt, then review the behavior discussed in pull request 384. Check how invalid frames are currently detected during collision or drawing and determine how creation-time warnings and replacement with 0 should work, while preserving the documented -1 empty-tile case. Done means both classes handle invalid frames at creation and no longer defer those checks.
Written by the indexing model from the issue text.
Assessment
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100