HaxeFlixel / HaxeFlixel/flixel-ui
FlxUI dropdown focus logic only works for widgets created from xml
Nobody has claimed this yet.
- Dominant language
- Haxe
- Stars
- 201
- Forks
- 75
- PR merge metrics
- No merged PRs in 30d
Description
There is special logic inside FlxUI.onFocus() to prevent clicking through the dropdown list of a FlxUIDropDownMenu (e.g. if there is a button under it). However, this logic iterates over the members of the FlxUI instance which does not include widgets created via code. Besides, there isn't a FlxUI instance in the first place without an _xml_id.
This leads to a bug in the FlxTween demo: HaxeFlixel/flixel-demos#159
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in FlxUI.onFocus() and inspect how its members are populated, then compare that path with FlxUIDropDownMenu widgets created from code rather than XML. Reproduce the click-through behavior from the FlxTween demo referenced in HaxeFlixel/flixel-demos#159; done means dropdown items prevent clicks from reaching widgets beneath them regardless of how the dropdown was created.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100