HathorNetwork / HathorNetwork/rfcs

Improvements on wallet-service opentelemetry

Open
#107 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
11
Forks
10
PR merge metrics
No merged PRs in 30d

Description

For me this is approved, I just have some questions:

> Storage costs. Traces generate significant data volume. Without sampling, costs can grow quickly. Tail-based sampling mitigates this but adds collector complexity.

Do we have an estimation on how much this will increase?

> ADOT layer cold start impact in our specific Lambdas. The 200-800ms range is from AWS documentation. We need to benchmark with our actual deployment packages to get exact numbers.

We should implement this feature with a simple feature flag (even if it's an ENV var) to turn it off in a simple way, if we feel it's adding lot of overhead, not only to the cold start.

---

Would be amazing to have an analysis for each alert created for the alert manager on how to improve the query/API/error being alerted.

_Originally posted by @pedroferreira1 in https://github.com/HathorNetwork/rfcs/pull/105#pullrequestreview-3993779788_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.