HarperFast / HarperFast/studio

Unbinding one domain resets generateDomainCerts for the whole cluster

Open
#1,626 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
5
Forks
4
Avg merge
1d 8h
Merged PRs (30d)
40

Description

Found while working HarperFast/central-manager#667 / central-manager#669.

`unbindDomainById` in `src/features/cluster/domains/constants/tableDefinition.tsx` (stage branch) hardcodes `generateDomainCerts: false` in the `setDomainIdsOnCluster` payload. When a cluster has multiple bound domains with cert generation enabled and the user unbinds just one, this resets cert intent for the whole cluster: CM's `updateDomains` stamps `generateDomainCerts: false` onto every RUNNING instance, and (once central-manager#669 lands) the Cluster row too — so later cluster expansions won't provision certs for the domains that remain bound.

Until central-manager#669 there was no durable cluster-level intent to consult, which is presumably why the flow hardcodes `false`. Once it lands, the unbind flow can send the cluster's persisted `generateDomainCerts` (or derive it from whether any remaining bound domain has certs enabled) instead of `false` when `domainIds` is non-empty.

Existing-behavior note: the already-issued cert on the remaining domains keeps renewing regardless (renewal is driven by the deployed component's `ChallengeCertificate` rows, not this flag) — the flag gates HM's provisioning of *new* instances, which is exactly the cluster-expansion path central-manager#667 is fixing.

— devain (Claude Fable 5)

Contributor guide

Open the contributing guide

Research direction

Start in src/features/cluster/domains/constants/tableDefinition.tsx at unbindDomainById and inspect the setDomainIdsOnCluster payload, then review central-manager#667 and #669 for the persisted cluster-level behavior. Done means unbinding one domain preserves certificate-generation intent for remaining domains while an empty domainIds case still disables it; verify the relevant cluster unbind and expansion behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.