HarperFast / HarperFast/studio

Take a pass through fields that could use the maxlength attribute

Open
#1,290 0 comments 0 reactions 0 assignees View on GitHub
ui consistency
Dominant language
TypeScript
Stars
5
Forks
4
Avg merge
1d 8h
Merged PRs (30d)
40

Description

The Role Name field, for example, clamps at 30 characters in the validation. But the input element lets you type whatever you want, only failing the validation after you've tried to submit the form. We can communicate the maxlength in other ways, or apply the maxlength attribute.

Notably we don't want to apply maxlength to everything. Some fields, particularly passwords, should never have maxlength. If someone puts in a password that's too long, we want to let them type it, but show a validation error. This will stop them from saving an invalid password in their password manager, pasting it, clamping it to some shorter different password, and then wondering why their password is wrong later.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.