HardstuckGuild / HardstuckGuild/HsBuildCodes

Land-Spears will intorduce issues with underwater builds

Open
#28 0 comments 0 reactions 0 assignees View on GitHub
enhancement low priority
Dominant language
PHP
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Generating underwater builds is likely going to be issues now that spears may be used on land.

We only save two weapon sets in the build code, and no indication on weather or not it is supposed to be terrestrial or underwater. Before this change we could just look at the weapons and determine if it should be underwater or terrestrial.

[this branch](https://github.com/HardstuckGuild/HsBuildCodes/tree/JW-land-spears) has modifications to the IsAquatic function to account for the change, but this issue is not solved by that function change.

Addressing this is low priority for now, as I don't know of anyone the would be using underwater builds. Let me know in case you are the one using it and i will figure something out.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.