HardstuckGuild / HardstuckGuild/GW2-Tooltips.js

Mislabeling of weapon skills

Open
#130 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Examples of Dagger 3 and Greatsword 5 on a [Harbinger page](https://hardstuck.gg/gw2/builds/necromancer/power-quickness-harbinger/)

![7644](https://github.com/HardstuckGuild/GW2-Tooltips.js/assets/23245218/798c40af-0744-4fda-b345-8143d477eda0)
![7645](https://github.com/HardstuckGuild/GW2-Tooltips.js/assets/23245218/843bb30f-a29e-43dd-8ce7-fb3cc7092e62)

Greatsword 5 is labeled correctly on a [Reaper page](https://hardstuck.gg/gw2/builds/necromancer/power-reaper/) but Dagger 3 does not.

![7646](https://github.com/HardstuckGuild/GW2-Tooltips.js/assets/23245218/9f426505-3ae7-46a3-ad10-2e08cf3a7c47)

Dagger 3 is not labeled correctly even on [Core Necromancer](https://hardstuck.gg/gw2/builds/necromancer/core-necromancer-2/)

![7647](https://github.com/HardstuckGuild/GW2-Tooltips.js/assets/23245218/e9eaaeb9-86a4-41e7-8d2c-1706d273d6ac)

May or may not be related to #126

Code to review, may be caused by the specialization check, breaking with weapon mastery, it doesn't explain the mislabeling of dagger though. https://github.com/HardstuckGuild/GW2-Tooltips.js/blob/master/src/TooltipsV2.ts#L899

Contributor guide

Open the contributing guide

Research direction

Start at src/TooltipsV2.ts around line 899 and compare the weapon-skill labeling on the Harbinger, Reaper, and Core Necromancer pages linked in the issue. Check whether the specialization check interacts with weapon mastery and whether it explains both Dagger 3 and Greatsword 5. Done means the affected skills are labeled correctly across those pages.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.