HardstuckGuild / HardstuckGuild/GW2-Tooltips.js

Crit modifying traits dont apply

Open
#105 0 comments 0 reactions 0 assignees View on GitHub
API bug
Dominant language
TypeScript
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

[Crit modifying traits](https://wiki.guildwars2.com/wiki/Critical_Damage) currently don't get processed properly since they are usually conditional and don't expose any modifiers.
We might be able to detect those cases, but this might be a tricky one, especially since there are quire a few cases so hard coding them is non viable (frequent changes, more getting introduced etc.)

Example is https://gw2-api.hardstuck.gg/traits/1453

Contributor guide

Open the contributing guide

Research direction

The issue names no files or tests. Start by reproducing the tooltip for trait 1453 from the linked example and tracing how trait modifiers are processed. Done means conditional critical-damage modifiers are detected and displayed correctly without hard-coding individual traits.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.