HarbourMasters / HarbourMasters/SpaghettiKart

Build fails

Open
#522 23 comments 0 reactions 0 assignees View on GitHub
need investigation
Dominant language
C
Stars
2.3k
Forks
143
Avg merge
7d 15h
Merged PRs (30d)
1

Description

Build fails on current revision with ambiguous overload.

```
/home/asdf/src/SpaghettiKart/src/port/GameExtractor.cpp:59:81: error: call of overloaded ‘Companion(const std::vector&, ArchiveType, bool)’ is ambiguous
59 | Companion::Instance = new Companion(this->mGameData, ArchiveType::O2R, false);
| ^
/home/asdf/src/SpaghettiKart/torch/src/Companion.h:138:14: note: candidate: ‘Companion::Companion(std::vector, ArchiveType, bool, const std::string&, const std::string&)’
138 | explicit Companion(std::vector rom, const ArchiveType otr, const bool debug, const std::string& srcDir = "", const std::string& destPath = "") :
| ^~~~~~~~~
/home/asdf/src/SpaghettiKart/torch/src/Companion.h:125:14: note: candidate: ‘Companion::Companion(std::vector, ArchiveType, bool, bool, const std::string&, const std::string&)’
125 | explicit Companion(std::vector rom, const ArchiveType otr, const bool debug, const bool modding = false,
| ^~~~~~~~~
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/port/GameExtractor.cpp at line 59 and the two Companion constructors in torch/src/Companion.h at lines 125 and 138. Inspect how the constructor call becomes ambiguous, make the intended overload unambiguous, then rebuild the project to confirm the current revision compiles.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.