HarbourMasters / HarbourMasters/Shipwright

[Bug?] Crash when reopening SoH after turning "Resource logging" setting on

Open
#7,166 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
5.4k
Forks
837
Avg merge
1d 9h
Merged PRs (30d)
72

Description

As of develop version 86a55cb1fbe50243d838dc674a765ec2b4d78ab3 at the least, if I turn on the "Resource logging" option on, then SoH will crash every time it is reopened after that until the variable is forcefully turned off through editing/deleting the settings file. A video example of this crash is below:

https://github.com/user-attachments/assets/b6043906-e8a1-4788-8b22-de20a74e54ce

This was actually happening to me on recent develop versions prior to this one, but this is the latest version I tested the issue on. I first mentioned it in the Discord server here: https://discord.com/channels/808039310850130000/1019824570938699798/1546643037755543702. If it helps, my OS version is Windows 11.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the crash on Windows 11 using develop commit 86a55cb1fbe50243d838dc674a765ec2b4d78ab3: enable "Resource logging," close SoH, and reopen it. Inspect the settings-file handling and the startup path for this option; done means SoH reopens normally with Resource logging enabled and no manual settings-file edit is required.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.