HarbourMasters / HarbourMasters/Shipwright

Loading old settings into [develop] and changing actor viewer settings can cause crashes that delete settings.

Open
#5,578 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
5.4k
Forks
837
Avg merge
1d 9h
Merged PRs (30d)
72

Description

The culprit is changes in file type to gDeveloperTools.ActorViewer, which causes a crash when the new format tried to open a primitive as a dict, which is not properly migrated.

Test file https://discord.com/channels/808039310850130000/1019824570938699798/1382507449923272806

Call Stack:
```__cxxabiv1::__cxa_throw(void *, std::type_info *, void (*)(void *)) (@__cxa_throw:3)
nlohmann::json_abi_v3_12_0::basic_json, std::allocator>, bool, long, unsigned long, double, std::allocator, nlohmann::json_abi_v3_12_0::adl_serializer, std::vector>, void>& nlohmann::json_abi_v3_12_0::json_pointer, std::allocator>>::get_and_create, std::allocator>, bool, long, unsigned long, double, std::allocator, nlohmann::json_abi_v3_12_0::adl_serializer, std::vector>, void>>(nlohmann::json_abi_v3_12_0::basic_json, std::allocator>, bool, long, unsigned long, double, std::allocator, nlohmann::json_abi_v3_12_0::adl_serializer, std::vector>, void>&) const (/usr/include/nlohmann/detail/json_pointer.hpp:327)
nlohmann::json_abi_v3_12_0::basic_json, std::allocator>, bool, long, unsigned long, double, std::allocator, nlohmann::json_abi_v3_12_0::adl_serializer, std::vector>, void> nlohmann::json_abi_v3_12_0::json_pointer, std::allocator>>::unflatten, std::allocator>, bool, long, unsigned long, double, std::allocator, nlohmann::json_abi_v3_12_0::adl_serializer, std::vector>, void>>(nlohmann::json_abi_v3_12_0::basic_json, std::allocator>, bool, long, unsigned long, double, std::allocator, nlohmann::json_abi_v3_12_0::adl_serializer, std::vector>, void> const&) (/usr/include/nlohmann/detail/json_pointer.hpp:828)
nlohmann::json_abi_v3_12_0::basic_json, std::allocator>, bool, long, unsigned long, double, std::allocator, nlohmann::json_abi_v3_12_0::adl_serializer, std::vector>, void>::unflatten() const (/usr/include/nlohmann/json.hpp:4733)
Ship::Config::Save() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/config/Config.cpp:217)
Ship::ConsoleVariable::Save() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/config/ConsoleVariable.cpp:276)
::CVarSave() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/public/bridge/consolevariablebridge.cpp:86)
Ship::Gui::CheckSaveCvars() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/window/gui/Gui.cpp:716)
Ship::Gui::EndDraw() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/window/gui/Gui.cpp:738)
Fast::Fast3dWindow::DrawAndRunGraphicsCommands(Gfx*, std::unordered_map, std::equal_to, std::allocator>> const&) (/home/pepper0ni/github/ShipwrightFork/libultraship/src/graphic/Fast3D/Fast3dWindow.cpp:190)
RunCommands(Gfx*, std::vector, std::equal_to, std::allocator>>, std::allocator, std::equal_to, std::allocator>>>> const&) (/home/pepper0ni/github/ShipwrightFork/soh/soh/OTRGlobals.cpp:1467)
::Graph_ProcessGfxCommands(Gfx *) (/home/pepper0ni/github/ShipwrightFork/soh/soh/OTRGlobals.cpp:1521)
RunFrame (/home/pepper0ni/github/ShipwrightFork/soh/src/code/graph.c:494)
Graph_ThreadEntry (/home/pepper0ni/github/ShipwrightFork/soh/src/code/graph.c:518)
Main (/home/pepper0ni/github/ShipwrightFork/soh/src/code/main.c:140)
main (/home/pepper0ni/github/ShipwrightFork/soh/src/code/main.c:67)
___lldb_unnamed_symbol3290 (@___lldb_unnamed_symbol3290:27)
__libc_start_main (@__libc_start_main:44)
_start (@_start:15)```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.