HarbourMasters / HarbourMasters/Shipwright

Use Audio_PlayFanfare_Rando() for skipped get-item animations

Open
#5,014 0 comments 0 reactions 0 assignees View on GitHub
randomizer
Dominant language
C
Stars
5.4k
Forks
837
Avg merge
1d 9h
Merged PRs (30d)
72

Description

Currently, picking up items while using the "Skip get-item animations" timesaver just plays `Audio_PlaySoundGeneral(NA_SE_SY_GET_ITEM)` for each item pickup, regardless of the item (major, minor, junk, etc). There was a discussion of changing that to `Audio_PlayFanfare_Rando()` to provide some audio feedback based on the item the player picks up.

https://github.com/user-attachments/assets/17417be3-af66-4936-80c3-aecf571aa0d2

Some discussion took place in discord here https://discord.com/channels/808039310850130000/1019824570938699798/1337264206772310058

It's not yet decided whether it should be changed outright, given an toggleable option, or left as-is.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.