HarbourMasters / HarbourMasters/Shipwright

Add plurals support for item count custom messages

Open
#4,420 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
5.4k
Forks
837
Avg merge
1d 9h
Merged PRs (30d)
72

Description

The custom messages are defined in `soh/soh/z_message_OTR.cpp`. They replace the normal item get messages for:
- Gold Skulltulas
- Heart Pieces
- Heart Containers

If you only have 1, the count will still be followed by the item's name in its plural form. It should be singular the first time one of those items is collected.

![2024-10-15 (5)](https://github.com/user-attachments/assets/69011518-3eff-41e5-84db-3f02d87a0af5)

![2024-10-15 (6)](https://github.com/user-attachments/assets/440b7521-d6dc-4301-b211-b81deb7c200a)

![2024-10-15 (7)](https://github.com/user-attachments/assets/e5e25667-5a14-4b51-8f3a-5a4f157823e9)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.