HarbourMasters / HarbourMasters/Shipwright

SoH does not use the authentic libultra implementations for math functions such as cosf, nor emulate intrinsics

Open
#2,935 0 comments 0 reactions 0 assignees View on GitHub
libultraship
Dominant language
C
Stars
5.4k
Forks
837
Avg merge
1d 9h
Merged PRs (30d)
72

Description

OoT did not use any part of what would be considered the C standard library. Instead, libultra provided functions that acted the same, such as `cosf` and `sinf`. Additionally, OoT utilized intrinsics for `fabsf`, `sqrtf`, and `sqrt`.

As it currently is, we do not utilize neither libultra's implementation of math functions, nor emulate the hardware's implementation of intrinsics. Instead, we utilize whatever C standard library's implementation of them. This is probably not inaccurate, but it _is_ inaccurate, Accordingly, we should either document this, or provide a way to get the accurate behavior. Additionally, there may be a task for libultraship to provide accurate libultra implementations for these functions.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.