HarbourMasters / HarbourMasters/Shipwright

Cosmetics Editor v3 - Known issues and TODOs

Open
#2,113 7 comments 0 reactions 0 assignees View on GitHub
epic
Dominant language
C
Stars
5.4k
Forks
837
Avg merge
1d 9h
Merged PRs (30d)
72

Description

Anyone is able to take these on, if you need any help or pointers on adding additional cosmetics reach out to me on discord `@ProxySaw`

# Todo List
- [ ] Clean up UI at the top of the window to be a bit cleaner
- Rainbow slider Tweaks
- [ ] Reverse direction, so that faster is to the right, slower to the left
- [ ] Describe what the number does (eg: full color cycle every x seconds)
- [ ] Allow for even slower cycling
- [x] Rainbow color "popping" every 10 to 20 seconds (this is a me being bad at math thing I think)
- Missing cosmetics from v2
- [ ] Title screen fire
- [ ] Magic effects
- Additional cosmetics
- [ ] Health fairy color
- [ ] Hookshot
- [ ] Gradient trail colors

# Known issues
- [ ] Some textures can only be as bright as the original color, notably link's hair, boots and gloves.
- [ ] Start/A/B color previews should respect color scheme (just the previews arent, the in game colors are)
- [ ] Shop cursor flashes for some colors
- [ ] In some cases when there are two colors to customize for an item, if the colors are too different(?) there is some weird clamping happening turning parts of the color black. This happens with the master sword when it's in the pedestal and some of the magic effects. This could be related to the reason saria's song has black color clamping in it's texture. I have verified this issue was introduced [here](https://github.com/HarbourMasters/Shipwright/pull/1753/files)
- [x] Crash when re-sizing link on file select menu

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.