HarbourMasters / HarbourMasters/Ghostship

Crash After "Save and Quit"

Open
#133 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C
Stars
739
Forks
51
Avg merge
15h 39m
Merged PRs (30d)
29

Description

### Crash after "Save and Quit" :
Choosing "Save and Quit" after completing a level can lead to a crash, either directly, or if trying to start a new game on the 3D Mario menu after Save and Quit

### Can you reproduce? If so please list the steps:
- [ ] No, I cannot reproduce this crash
- [X] Yes, here are the steps to reproduce the crash:
1. Finish a level
2. Choose "Save and Quit"
3. Crash, or sometimes you can get to the 3D Mario screen, and then if you choose Start it crashes.

### Screenshots or videos:

### Logs:
[15:26:03.652] [Engine.cpp:199] [info] Starting Ghostship version Dutchman Charlie (1.0.2) (Branch: | Commit: b9cb71f)
[15:26:03.653] [ArchiveManager.cpp:240] [info] Reading archive: /mnt/Games/Ghostship/./sm64.o2r
[15:26:03.664] [ArchiveManager.cpp:272] [info] Adding Archive /mnt/Games/Ghostship/./sm64.o2r to Archive Manager
[15:26:03.668] [ArchiveManager.cpp:240] [info] Reading archive: /tmp/.mount_ghostsDyG2jz/usr/bin/ghostship.o2r
[15:26:03.668] [ArchiveManager.cpp:272] [info] Adding Archive /tmp/.mount_ghostsDyG2jz/usr/bin/ghostship.o2r to Archive Manager
[15:26:03.668] [ArchiveManager.cpp:240] [info] Reading archive: /mnt/Games/Ghostship/./mods/sm64-reloaded-v2.5.1-gs.o2r
[15:26:03.670] [ArchiveManager.cpp:272] [info] Adding Archive /mnt/Games/Ghostship/./mods/sm64-reloaded-v2.5.1-gs.o2r to Archive Manager
[15:26:03.775] [os.cpp:21] [info] Added SDL game controllers from "./gamecontrollerdb.txt" (702)
[15:26:04.284] [GenericArrayFactory.cpp:18] [info] GenericArray Type Num: 7
[15:26:04.284] [GenericArrayFactory.cpp:22] [info] GenericArray Count: 60
[15:26:04.284] [GenericArrayFactory.cpp:18] [info] GenericArray Type Num: 7
[15:26:04.284] [GenericArrayFactory.cpp:22] [info] GenericArray Count: 48
[15:27:17.615] [GenericArrayFactory.cpp:18] [info] GenericArray Type Num: 3
[15:27:17.615] [GenericArrayFactory.cpp:22] [info] GenericArray Count: 1265
[15:27:17.615] [GenericArrayFactory.cpp:18] [info] GenericArray Type Num: 3
[15:27:17.615] [GenericArrayFactory.cpp:22] [info] GenericArray Count: 949

### System Information:
- OS: Garuda Linux (Arch) on kernel 6.18.6-zen1-1-zen
- GFX Backend: OpenGL
- Game Version: 1.0.2
- Rom Version: Super Mario 64 (U) [!].z64

### Additional Information:
Wayland compositor
Launching the appimage through Lutris manager

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the level completion, Save and Quit, and subsequent Start flow described in the issue. Begin by reviewing the logged entry points in Engine.cpp, ArchiveManager.cpp, and GenericArrayFactory.cpp, then obtain a crash trace for the failing path. Done means the game no longer crashes in either reported scenario on the tested setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.