HappyHackingSpace / HappyHackingSpace/CommunityHub

fix(security): Rate limiting is configured but never enforced

Open
#39 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3
Forks
6
PR merge metrics
No merged PRs in 30d

Description

`ThrottlerModule.forRoot` is configured (app.module.ts:70) but no global `ThrottlerGuard` is registered (no `APP_GUARD` anywhere). Only `ApiKeyThrottlerGuard` is applied manually to a few controllers, so most endpoints, including auth, are not rate-limited. The config gives a false sense of protection.

Contributor guide

Open the contributing guide

Research direction

Start by reading app.module.ts around line 70 and locating the existing ApiKeyThrottlerGuard applications. Trace how guards are registered, then verify that throttling is enforced globally, including on auth routes, and that the configured rate limit is no longer merely declarative.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.