HangfireIO / HangfireIO/Hangfire
why the .net core version dashboard not support cronDescription
- Dominant language
- C#
- Stars
- 10.1k
- Forks
- 1.8k
- Avg merge
- 1h 19m
- Merged PRs (30d)
- 1
Description
i saw the code in https://github.com/HangfireIO/Hangfire/blob/master/src/Hangfire.Core/Dashboard/Pages/RecurringJobsPage.cshtml
```
@* ReSharper disable once EmptyGeneralCatchClause *@
@{
string cronDescription = null;
#if NETFULL
try
{
cronDescription = string.IsNullOrEmpty(job.Cron) ? null : CronExpressionDescriptor.ExpressionDescriptor.GetDescription(job.Cron);
}
catch (FormatException)
{
}
#endif
}
@if (cronDescription != null)
{
@job.Cron
}
else
{
@job.Cron
}
```
why we need add #if NETFULL ?
Contributor guide
Research direction
Start with src/Hangfire.Core/Dashboard/Pages/RecurringJobsPage.cshtml and inspect why the cron description is conditional on NETFULL. Compare the dashboard behavior on .NET Core and .NET Framework, then determine whether cron descriptions can be supported on .NET Core; done means the reason for the conditional is resolved and the supported behavior is clear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100