HangfireIO / HangfireIO/Hangfire
Calling Dispose() on custom IPersistentJobQueue
- Dominant language
- C#
- Stars
- 10.1k
- Forks
- 1.8k
- Avg merge
- 1h 19m
- Merged PRs (30d)
- 1
Description
On server stopping Hangfire may call Dispose() if implementation of IPersistentJobQueue has IDisposable interface.
Sometimes it makes sense, e.g. when IPersistentJobQueue implementation keeps open connection and should close it right on Hangfire server stopping instead of waiting until GC kicks in.
Contributor guide
Research direction
Locate the IPersistentJobQueue interface and the Hangfire server-stopping path first. Check how queue implementations are managed during shutdown, then verify the requested behavior with the existing test structure if available: an implementation that also implements IDisposable should be disposed when the server stops, while other implementations should continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100