HangfireIO / HangfireIO/Hangfire
Strong name signed version
- Dominant language
- C#
- Stars
- 10.1k
- Forks
- 1.8k
- Avg merge
- 1h 19m
- Merged PRs (30d)
- 1
Description
Working today with an ecommerce platfor and looking into if we can use Hangfire for scheduled jobs. The only problem that I see today is that we need to ship all our assemblies strong name signed and can't make a reference to Hangfire because of the lack of strong name signed assemblies.
From https://github.com/aspnet/DataProtection/issues/245#issuecomment-307155485 that davidfowl write
> Package authors realistically all need to be strong named and we (Microsoft) need to fix the .NET Framework to not require binding redirects to truly solve the problems that people hit (I'm fighting for this, again 😄).
Is there any possibility that atleast the "core" package (this repro) can be strong name signed?
---
I found the following issued about strong naming signing
* #1 `Sign assemblies with strong names` was closed because of service stack not was signed
* #41 `Consider about ServiceStack.* dependencies` was removing service stack, in the descriptions it says that you want Hangfire to be signed.
* #54 `To sign or not to sign the assemblies` was closed with comment that you not believe that anybody need it, but a comment on that issue exists from user that needing strong named version.
And if we check the thirdparty that are used and if the support strong naming for this repo
* [x] Owin
* [x] Microsofts.* all assemblies are strong name signed
* [x] Ssytem.* all assemblies are strong name signed
* [ ] Dapper, it exists a `Dapper.StringNaming` that is a signed replacement and it looks like V2 will only be strong name signed https://github.com/StackExchange/Dapper/issues/688
* [x] CronExpressionDescriptor
* [x] Newtonsoft.Json
* [ ] NCrontab, it exists `NCrontab.Signed` that is a signed replacement
* [ ] StackExchange.Redis (part of Hangfire.Pro), it exists `StackExchange.Redis.StrongName` that is a signed replacement and it looks like V2 will only be strong name signed https://github.com/StackExchange/StackExchange.Redis/issues/528
Dependencies that is placing source into Hangfire is not relevant to be strong name signed
* [x] LibLog
* [x] MoreLinq.Source.MoreEnumerable.Pairwise
* [x] StackTraceFormatter.Source
* [x] StackTraceParser.Source
Contributor guide
Research direction
The issue names no files, tests, or entry points. Review the core package and its listed dependencies, especially Dapper, NCrontab, and the Hangfire.Pro Redis dependency, to determine whether strong-name signing is possible; done means the relevant core assemblies and package dependencies are signed and usable by strong-named applications.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100