HangfireIO / HangfireIO/Hangfire
AspNetCoreJobActivator does not override JobActivator.ActivateJob
- Dominant language
- C#
- Stars
- 10.1k
- Forks
- 1.8k
- Avg merge
- 1h 19m
- Merged PRs (30d)
- 1
Description
https://github.com/HangfireIO/Hangfire/blob/6525aa314f65d1a029863928edf8c9cfc18ec30d/src/Hangfire.AspNetCore/AspNetCore/AspNetCoreJobActivator.cs#L23
On the `AspNetCoreJobActivator`, is there no need to override `JobActivator.ActivateJob(Type jobType)` ?
It seems to work well though.
Contributor guide
Research direction
Start with src/Hangfire.AspNetCore/AspNetCore/AspNetCoreJobActivator.cs at line 23, then compare it with the base JobActivator.ActivateJob(Type jobType) implementation. Determine whether the ASP.NET Core activator needs an override and verify the behavior with the relevant existing tests, if any. Done means the activation behavior is confirmed or the missing override is addressed and covered by a test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100