HandyOrg / HandyOrg/HandyControl

A better theme enum?

Open
#1,039 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

:thinking: pending discussion
Dominant language
C#
Stars
7.2k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Right now there is a an enum with light and dark values:
Themes.Light and Themes.Dark
And for switching to system theme we need to set IsUsingSystemTheme = true.

How about having a enum to include the system theme:

Themes.Light, Themes.Dark, Themes.System and Themes.SystemWithDefaultAccentColor

When Themes.System is selected the background color scheme and accent color follows the system theme. This the same as setting IsUsingSystemTheme = True.

And, When Themes.SystemWithDefaultAccent is selected the background color scheme follows the system theme. But the Accent color remains default. This the same as setting

IsUsingSystemTheme =  True
AccentBrush = null

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Themes enum and the existing IsUsingSystemTheme and AccentBrush entry points. Define how Themes.System and the default-accent system option should map to the current behavior, resolve the naming discrepancy in the proposal, and verify both background and accent-color outcomes.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.