HandyOrg / HandyOrg/HandyControl
Do not use the Style property to provide default appearance, use DefaultStyleKey instead.
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 7.2k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
You should use the DefaultStyle property to provide default appearance and let user to use the Style property to modify it.
Now you occupied the Style property, so we can only use a style with a BasedOn. Without it, the new style with few setters will replace the original style and makes the control invisible.
Why not set the DefaultStyleKey property like normal custom controls? Using the DefaultStyleKey can also help the control display normally even without adding the HandyControl's resource dictionary.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the control that currently occupies the Style property and the HandyControl resource dictionary that provides its default appearance. Compare its behavior with WPF custom controls using DefaultStyleKey; done means a user can apply a style without BasedOn and the control still displays normally without adding HandyControl's resource dictionary.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100