HandBrake / HandBrake/HandBrake
Allow choosing *.smi as valid subtitle file
Open
Nobody has claimed this yet.
Enhancement
- Dominant language
- C
- Stars
- 24.4k
- Forks
- 1.7k
- Avg merge
- 5d 1h
- Merged PRs (30d)
- 8
Description
Description of the feature or enhancement you'd like to see in HandBrake
I'd like to add my SAMI files as subtitles. It seems like FFmpeg supports this (Jellyfin uses them) and it is widely used in South Korea as a common file type for distributing subtitles.
What Operating System are you running?
Windows 11 21H2 22000.675
What version of HandBrake are you running?
Nightly 20220515151217-37c9b9f53-master
Where did you download HandBrake from?
https://github.com/HandBrake/HandBrake-snapshots
Activity Log, Crash Log or any other details
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the report. Start by tracing the subtitle-file handling that determines whether *.smi files are accepted, then check the FFmpeg support referenced in the issue. Done means a SAMI file is accepted as a subtitle input without regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- audio-video-rtc
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100