HSLdevcom / HSLdevcom/digitransit-ui

yarn resolution warnings

Open
#4,742 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
267
Forks
145
Avg merge
1d 15h
Merged PRs (30d)
75

Description

yarn run setup currently reports various warnings in the resolution step.
They can be grouped in the following categories:

  1. missing peerDependencies (YN0002) in digitransit-ui or digitransit-ui-components
  2. missing peerDependencies (YN0002) in hsl components
  3. missing peerDependencies (YN0002) in third party components
  4. not-satisfying versions provided (YN0060)

I suggest the following actions to resolve these warnings:

  1. fix declared peerDependencies in digitransit-ui or digitransit-ui-components
  2. fix declared peerDependencies in hsl-fi packages and upgrade digitransit-ui to updated versions
  3. As temporary fix, add missing peerDependencies as packageExtensions to .yarnrc.yml and mid-term upgrade concerned packages (assuming they are fixed in the meantime, otherwise suggest fixes there)
  4. check and correct versions. IMHO most clashes are caused by fixed versions in package.json, where rather ranges should be specified.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running yarn run setup and grouping the reported YN0002 and YN0060 warnings by package. Review the peerDependencies in digitransit-ui, digitransit-ui-components, and hsl-fi packages, along with package.json and .yarnrc.yml. Done means the resolution step no longer reports these warnings, with temporary packageExtensions used only where necessary.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.