HSLdevcom / HSLdevcom/digitransit-ui

Suboptimal routing with trams 2/3

Open
#473 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
267
Forks
145
Avg merge
1d 15h
Merged PRs (30d)
75

Description

Trams 2 and 3 are special in a way that the tram numbers get swapped on two stops: "Olympialaituri" and "Eläintarha". This leads to suboptimal routing when the tram 2 or 3 would be crossing these stops. In particular: the routing assumes that passengers need to hop off the tram and wait for the next one (if you're in tram 3, you are asked to hop off, wait for 7-8 mins and then hop on to tram 2, and vice versa). In reality the tram number is changed on the fly and the tram continues from the stop without delay.

Since the routing thinks there's an extra 7-8 minutes in this route, alternate routes get priority over this faster one.

Here's a demonstration of the subobtimal routing (enforced by disliking walking):
https://sintonen.fi/pics/hsl-tram-2-3-routing-fail.png

PS. This issue exists in the old route planner, too. It's about time to get this fixed...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points, so first trace where routing decisions for tram routes 2 and 3 are obtained or assembled in this repository. Reproduce the shown route and identify the relevant routing data or integration; done means the planner treats the tram-number change at Olympialaituri and Eläintarha as continuous travel without the extra wait.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.