HSLdevcom / HSLdevcom/digitransit-ui
getLayerBaseUrl does not work for string literals
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 267
- Forks
- 145
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 75
Description
In line mapLayerUtils.getLayerBaseUrl the check urlOrUrlMap instanceof String returns false for string literals and should be replaced by e.g. typeof urlOrUrlMap === 'string'.
There might be further occurences where such a check might fail.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in app/util/mapLayerUtils.js at getLayerBaseUrl around line 142, then search the repository for other instanceof String checks. Confirm that string literals are handled correctly by getLayerBaseUrl and review any other matching checks for the same issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100