HSLdevcom / HSLdevcom/digitransit-ui
Make feed_id in realTimeClient auto-discoverable
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 267
- Forks
- 145
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 75
Description
(Based on Slack with Tuuka, feel free to edit/clarify, Alex Loyko will pick this up)
Currently, the realTimeClientAction has HSL hard coded into requests:
https://github.com/HSLdevcom/digitransit-ui/blob/master/app/action/realTimeClientAction.js#L29
A longer-term solution would be to remove the hardcoding and include the feed id in the mqtt topic instead.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in app/action/realTimeClientAction.js around line 29, where HSL is hard coded into real-time requests. Trace how the MQTT topic is built and consumed, then verify that the feed id is obtained from the topic and requests no longer depend on a hard-coded HSL value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100