HSLdevcom / HSLdevcom/digitransit-ui
config.default.js should allow the configuration of the router
Open
Nobody has claimed this yet.
new feature
- Dominant language
- JavaScript
- Stars
- 267
- Forks
- 145
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 75
Description
Instead it is hardcoded for finland. I think that for consistency adding env ROUTER_NAME as in OTP could be a good idea, no ?
Line 20: OTP: ${API_URL}/routing/v1/routers/finland/,
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open config.default.js and inspect line 20, where OTP uses the hardcoded Finland router URL. Compare this configuration with the OTP environment setting mentioned in the issue; done means the router name can be configured through ROUTER_NAME instead of being fixed to finland.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100