HSF / HSF/phoenix

Clean up Phoenix bar.

Open
#903 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
88
Forks
105
Avg merge
16h 15m
Merged PRs (30d)
34

Description

A lot of very cool new functionality has been added, but this has had the consequence that the Phoenix menu bar (the bottom bar) is becoming very full. Before we make a new major release, I think we should try to clean this up (because it is potentially a breaking change, if clients have suppressed some of the interface options).

Image

The default menu is defined here: https://github.com/HSF/phoenix/blob/main/packages/phoenix-ng/projects/phoenix-ui-components/lib/components/ui-menu/ui-menu.component.html

We still want to keep the main options easily accessible, so we need to balance a little having it compact and still usable.

Options could include:

  • Move the dark/light theme into "View options"
    • Orthographic/perspective could in principle go there too, but I think it should probably stay at the top level as it is very useful and you might want to rapidly click it off/on
  • Browsers
    • We could move Event collections, Event Browser, and Geometry Browser into one top level menu

Thoughts @sponce?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/phoenix-ng/projects/phoenix-ui-components/lib/components/ui-menu/ui-menu.component.html, which defines the default menu. Review the current grouping and the proposed View options and Browsers groupings, then agree on a compact, usable arrangement that preserves the main options and accounts for clients that may have suppressed interface options.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
design, frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.