HDFGroup / HDFGroup/hermes

Rename TestWriteDataset() to TestMakeDataset() in hermes/adapter/test/vfd/hermes_vfd_test.cc.

Open
#461 2 comments 0 reactions 1 assignee Claimed by @lukemartinlogan View on GitHub
bug
Dominant language
C++
Stars
34
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Function naming is not consistent.

```
void TestWriteDataset(const std::string &dset_name,
const std::vector &data) {
Hdf5Api api;
api.MakeDataset(test::hermes_hid, dset_name, data);
api.MakeDataset(test::sec2_hid, dset_name, data);
}

void TestMakeCompactDataset(const std::string &dset_name,
const std::vector &data) {
Hdf5Api api;
api.MakeDataset(test::hermes_hid, dset_name, data, true);
api.MakeDataset(test::sec2_hid, dset_name, data, true);
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.