HDFGroup / HDFGroup/hdf5

Can't build with zlib-ng

Open
#5,901 5 comments 0 reactions 3 assignees Claimed by @lrknox View on GitHub
Component - Build HDFG_Internal_161
Dominant language
C
Stars
988
Forks
355
Avg merge
4d 2h
Merged PRs (30d)
12

Description

Version: 1.14.6.

```
add_third_party("gh:zlib-ng/zlib-ng@2.0.0-RC2"
USE_LOCAL_PACKAGES NO
OPTIONS
"ZLIB_ENABLE_TESTS OFF"
"ZLIB_COMPAT ON"
"ZLIBNG_ENABLE_TESTS OFF"
"SKIP_INSTALL_ALL ON")
...
add_third_party("gh:HDFGroup/hdf5#hdf5_1.14.6"
USE_LOCAL_PACKAGES NO
GIT_SHALLOW ON
FIND_PACKAGE_ARGUMENTS "NAMES hdf5 libhdf5 hdf5-static"
OPTIONS
"HDF5_EXTERNALLY_CONFIGURED ON"
"HDF5_BUILD_DOC OFF"
"HDF5_NO_PACKAGES ON"
"H5_ENABLE_STATIC_LIB ON"
"HDF5_BUILD_SHARED_LIBS ON"
"HDF5_BUILD_TOOLS OFF"
"HDF5_BUILD_UTILS OFF"
"HDF5_ENABLE_Z_LIB_SUPPORT ON"
"HDF5_USE_ZLIB_NG ON"
"HDF5_USE_ZLIB_STATIC ON"
"HDF5_VOL_ALLOW_EXTERNAL YES")
```

[CPMAddPackage() inside](https://github.com/KasperskyLab/knp/blob/master/CMakeLists.txt#L296).

Result:
```
-- Final: share
-- Checking if _Float16 support is available
-- ....All Warnings are enabled
CMake Error at third-party/hdf5/2e3e/CMakeFilters.cmake:134 (set_target_properties):
set_target_properties Can not find target to add properties to: ZLIB::ZLIB
Call Stack (most recent call first):
third-party/hdf5/2e3e/CMakeLists.txt:921 (include)
```

Zlib compat mode doesn't work too.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.