HDFGroup / HDFGroup/hdf5-pickles

pickles/*.pk: types with a stored address field have no `_print` method (raw bytes only, not decoded)

Open
#83 0 comments 0 reactions 1 assignee Claimed by @vchoi-hdfgroup View on GitHub
enhancement
Dominant language
Python
Stars
2
Forks
2
Avg merge
1d 12h
Merged PRs (30d)
12

Description

Across the shared format layer, several types decode a genuine HDF5 file
address field but define no `_print` method at all, so mapping and
printing one falls back to poke's default struct printer — a raw,
undecoded byte array rather than any kind of number. This isn't a
correctness bug, so it's split out from the address-translation bug fixed under #77.

Need to scan every `type ... = struct`/`union` in `pickles/*.pk` for a
field with `addr` in the name, then checking for `method _print`.

_Suggested fix_: for each verified type, add a `method _print` that decodes
and translates the address field(s) with `hdf5_addr_to_file_u64(bytes_to_u64_le(...))`,
matching the pattern already used throughout the fixes on #77.

_Scope:_ enhancement, `pickles/*.pk`. No behavior change to existing
correctness paths. Separate from issue #77 which is a correctness fix.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.