HDFGroup / HDFGroup/hdf4

type definition for tags / refs not consistent

Open
#850 0 comments 0 reactions 1 assignee Claimed by @bmribler View on GitHub
Component - Documentation
Dominant language
C
Stars
22
Forks
27
Avg merge
1d 3h
Merged PRs (30d)
22

Description

In some places (VQuerytag, VQueryref) the type of the tag and ref is defined to be int32.

In other places (ANcreate) it is declared to be uint16.

This leads to compiler warnings. And, I'm not sure what type to treat it as in the mapping project.

The examples given are just a couple... I think the inconsistency is more wide-spread.

(Original issue: HDFFR-230)
Summary of comments:

It is a known problem and we cannot change any of them, but I can go through warnings and add a cast where appropriate.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.