HDFGroup / HDFGroup/h5pyd

group link cache clean up logic looks wrong

Open
#276 1 comment 0 reactions 1 assignee Claimed by @jreadey View on GitHub
Dominant language
Python
Stars
124
Forks
46
Avg merge
1h 24m
Merged PRs (30d)
6

Description

https://github.com/HDFGroup/h5pyd/blob/master/h5pyd/_hl/group.py#L978
```
for n in name:
if n.find('/') == -1 and n in self._link_db:
# remove from link cache
del self._link_db[name]
```

If `name` is a list, it would attempt to delete the list which doesn't exist in the _link_db cache.
If `name` is a string, it would iterate the characters so `n` wouldn't be in the _link_db cache.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.