Easy to accidentally use shellisms in fix and check targets
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 3
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
I got this failure for a setup:
ERROR: "bundle check" was called with arguments ["&&", "bundle", "install"]
Usage: "bundle check [OPTIONS]"
ERROR Check `bundle-update` failed. The fix ran and Failed.
Turns out it was because I was using &&:
apiVersion: scope.github.com/v1alpha
kind: ScopeDoctorSetup
metadata:
name: bundle-update
spec:
# order: 100 # default value
cache:
paths:
- Gemfile*
- .ruby-version
setup:
exec:
- bundle check && bundle install
description: Check for updates to bundled dependencies
I wonder if it's useful to always run things in a shell? Or if it could be identifed with a better error message?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the setup.exec command handling and reproduce the failure using the ScopeDoctorSetup YAML shown in the issue. Compare the behavior of shell operators such as && with the current error output; done means the chosen command-handling behavior is defined and the resulting failure is reported clearly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust, shell
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100