Gunnstein / Gunnstein/fatpack

Error in find_rainflow_ranges for boundary cases

Open
#14 5 comments 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
Python
Stars
157
Forks
29
PR merge metrics
No merged PRs in 30d

Description

find_rainflow_ranges gives error for arbitrary numpy array. For example if the array doesn't contain any cycles - fatpack.find_rainflow_ranges(np.array([1,2,3,4,5]), return_means=True, k=2**14) produces error.

![image](https://user-images.githubusercontent.com/24558167/197655422-fa620696-7bd9-4aed-ad8e-dd194f73cc38.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the error with fatpack.find_rainflow_ranges(np.array([1,2,3,4,5]), return_means=True, k=2**14), then locate that function and inspect its handling of arrays containing no cycles. Done means the boundary case returns a valid result instead of raising an error, with coverage for the provided example.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
56/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.